Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary header includes #652

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Aug 7, 2024

#567 is a mess so let's divide it in the deletions and additions and then it will be easier to see what's going on. In addition, the deletions should be quite uncontroversial.

BEGINRELEASENOTES

  • Remove unnecessary header includes

ENDRELEASENOTES

@andresailer andresailer changed the title Remove unnecessary headers Remove unnecessary header includes Aug 9, 2024
@andresailer
Copy link
Member

Too much removed, breaking the build against LCG_105?

@jmcarcell
Copy link
Member Author

Now fixed

@tmadlener
Copy link
Collaborator

pre-commit workflow should be fixed with #654. Can you pick that up?

@tmadlener tmadlener merged commit 407c84f into AIDASoft:master Aug 22, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants