Add Site Multiplicities to Structure Specific Metadata #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewcarbone
approved these changes
Feb 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #248 +/- ##
==========================================
+ Coverage 44.94% 47.23% +2.29%
==========================================
Files 15 15
Lines 1266 1268 +2
==========================================
+ Hits 569 599 +30
+ Misses 697 669 -28 ☔ View full report in Codecov by Sentry. |
|
@xhqu1981 You good with me merging? Looks good to me overall! |
|
Yes. Please go ahead. Best, Xiaohui
…On Wed, Feb 28, 2024 at 8:22 PM Matthew Carbone ***@***.***> wrote:
@xhqu1981 <https://github.com/xhqu1981> You good with me merging? Looks
good to me overall!
—
Reply to this email directly, view it on GitHub
<#248 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDONX5C26FHIRMXWXM4QJDYV7J4JAVCNFSM6AAAAABD6HWXWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZQGIYDQMZQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@xhqu1981 It looks good to me. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The site multiplicities are added as a dictionary, mapping a site index into its multiplicity, to the metadata.json file in each structure folder.