Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An effect part of the condeff should be AndEffect and not And. #119

Merged
merged 9 commits into from
Aug 14, 2024

Conversation

haz
Copy link
Contributor

@haz haz commented Aug 9, 2024

Minor fix for #118

@haz haz requested a review from marcofavorito August 9, 2024 20:05
@haz
Copy link
Contributor Author

haz commented Aug 9, 2024

Probably best to wait for #120 to be resolved before this is merged (so we can be sure nothing's broken).

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (fef6c74) to head (21c17ee).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   87.98%   88.07%   +0.08%     
==========================================
  Files          24       24              
  Lines        1773     1752      -21     
  Branches      333      329       -4     
==========================================
- Hits         1560     1543      -17     
+ Misses        152      148       -4     
  Partials       61       61              
Flag Coverage Δ
unittests 88.07% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pddl/_validation.py 91.41% <100.00%> (ø)
pddl/logic/effects.py 86.44% <100.00%> (+1.44%) ⬆️
pddl/parser/domain.py 76.17% <100.00%> (ø)
pddl/parser/problem.py 67.42% <100.00%> (ø)

@haz haz mentioned this pull request Aug 13, 2024
@haz haz merged commit 42c8198 into main Aug 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants