Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

README.md #102

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 16, 2015

This is my readme

README.md
9750168 
This is my readme
@hargup
Copy link
Member

hargup commented Mar 16, 2015

@knightshell301 everything looks good except your commit message. Please modify it so that we know who's name is being added, it can be something like "Added Kenneth to README.md"

@abinashmeher999
Copy link
Member

@knightshell301 That is a comment, you need to edit you commit message. Your commit message is currently README.md, and your detailed commit message contains "This is my readme". You need to change README.md to Added Kenneth to README.md.
You can do that by using rebase feature of git, and a forced push to your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Need Better Commit Message Need rebase on latest master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hargup @abinashmeher999