Make input loading fallible in SyncFromDiskStage #3195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenukk
reviewed
May 5, 2025
domenukk
reviewed
May 6, 2025
…e if it is encountered
domenukk
reviewed
May 9, 2025
domenukk
reviewed
May 9, 2025
domenukk
reviewed
May 9, 2025
libafl_bolts/src/lib.rs
Outdated
| @@ -341,6 +341,8 @@ pub enum Error { | |||
| InvalidCorpus(String, ErrorBacktrace), | |||
| /// Error specific to a runtime like QEMU or Frida | |||
| Runtime(String, ErrorBacktrace), | |||
| /// The `Input` was invalid. | |||
| InvalidInput(ErrorBacktrace), | |||
There was a problem hiding this comment.
Wouldn't it make sense to include a string here? Like, the path of the invalid input, and maybe a root cause if there is any?
There was a problem hiding this comment.
Especially given the callback is user provided, adding a string will make things way easier to debug IMHO. The callback can differentiate between different invalid input causes
domenukk
reviewed
May 11, 2025
| let input = match (self.load_callback)(fuzzer, state, &path) { | ||
| Ok(input) => input, | ||
| Err(Error::InvalidInput(reason, _)) => { | ||
| log::debug!( |
There was a problem hiding this comment.
Or maybe info if you think it's expected
domenukk
reviewed
May 11, 2025
| @@ -1064,7 +1081,7 @@ pub fn get_thread_id() -> u64 { | |||
| #[allow(clippy::cast_sign_loss)] | |||
| /// Return thread ID without using TLS | |||
| pub fn get_thread_id() -> u64 { | |||
| use libc::{SYS_gettid, syscall}; | |||
| use libc::{syscall, SYS_gettid}; | |||
There was a problem hiding this comment.
is this a cargo fmt update of some sorts?
There was a problem hiding this comment.
Seems like your fmt is not the same as the CI one
|
Change debug to info and figure out how to make CI happy, then this is good to go <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
InvalidInputvariant inError. When syncing inSyncFromDiskStage, if such an error is encountered, it is logged and the file is skipped.Reasoning:
In the case of a grammar fuzzer loading inputs from other fuzzers, the inputs may be structurally invalid. This should not make it an error in the syncing process
Checklist
./scripts/precommit.shand addressed all comments