Skip to content

Track lockfiles #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 13, 2025
Merged

Track lockfiles #3015

merged 4 commits into from
Mar 13, 2025

Conversation

rmalmain
Copy link
Member

we had some issues compiling old versions of the project.
without lockfiles it's very hard to make things recompilable reliably.

Pull Request Checklist

Please make sure you've completed the following steps before submitting:

  • I have run ./script/fmt_all.sh to format the code
  • I have run ./script/clippy.sh and fixed all errors/warnings

@domenukk
Copy link
Member

domenukk commented Feb 21, 2025 •
edited
Loading

We shouldn't have a lockfile in the main lib, but we can have lockfiles in each example fuzzer

(see rust-lang/cargo#315 )

domenukk
domenukk reviewed Feb 21, 2025
View reviewed changes
.gitignore Outdated
@@ -1,7 +1,7 @@
target
target-bin
out
Cargo.lock
# Cargo.lock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding ./Cargo.lock here should work I think(?)

@rmalmain
Copy link
Member Author

yeah i was exactly working on this.
we need to have lockfiles for binary crates.
i'm fixing the gen stuff to only update lockfiles for binary crates in the repo

@domenukk
Copy link
Member

That being said some changes were rust version dependent, like the type_id magic, so they would not work even with lock

Still better with than without, though

@rmalmain
Copy link
Member Author

we can easily downgrade the version of the compiler, it's not the main problem.
the main issue is to find back the right version of the dependencies, since they are not perfectly fixed by Cargo.toml

@tokatoka
Copy link
Member

tokatoka commented Mar 7, 2025

can we generate lock file for all and get this merged?

domenukk
domenukk reviewed Mar 13, 2025
View reviewed changes
.gitignore Outdated
@@ -88,3 +93,6 @@ rustc-ice-*

# log
log

# Coredumps
**/*.core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just *.core would be sufficient

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

domenukk
domenukk reviewed Mar 13, 2025
View reviewed changes
@rmalmain rmalmain merged commit 85bcafa into main Mar 13, 2025
110 checks passed
@rmalmain rmalmain deleted the track_lockfiles branch March 13, 2025 11:32
Marcondiro pushed a commit to Marcondiro/LibAFL that referenced this pull request Apr 1, 2025
@rmalmain @Marcondiro
Track lockfiles (AFLplusplus#3015)
6e0260c 
* rename libafl_fmt into liabfl_repo_tools

* add option to generate lockfiles

* only keep binary lockfiles (update gitignore)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenukk domenukk domenukk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmalmain @domenukk @tokatoka