Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preliminary adaptive resolution #26

Merged
merged 9 commits into from
May 15, 2020
Merged

Preliminary adaptive resolution #26

merged 9 commits into from
May 15, 2020

Conversation

bprather
Copy link
Collaborator

@bprather bprather commented Dec 3, 2019

  • All the nice re-organization preliminaries
  • Probably doesn't leak too much memory
  • Heuristic for refinement may need to be refined

Ben Prather added 4 commits November 30, 2019 18:07
Preliminary adaptive resolution
712aabf 
* All the nice re-organization preliminaries
* Probably doesn't leak too much memory
* Heuristic for refinement may need to be refined
Try a new refinement criterion
4d80279
Linear interpolation at every level. Potentially problematic levels o…
8774be6 
…f bleed.
Merge branch 'master' into feature/adaptive-res
2e776f7
@bprather bprather changed the base branch from master to dev February 21, 2020 23:11
@bprather
Copy link
Collaborator Author

This is currently blocked on:

  1. Slow light test, to make sure I haven't broken it
  2. Adaptive res regression test, to ensure adaptive images never look truly crazy compared to full-res
  3. Knowing what to do w.r.t. interpolation. Currently uses straight bi-linear, but interpolating from interpolated pixels is fuzzy. May need to keep track of calculated vs interpolated pixels & use just the former.
    The heuristic could always use work, suggestions welcome...

Ben Prather added 5 commits April 3, 2020 12:48
Initial merge of new coordinates stuff to adaptive work
a341dcc
Merge remote-tracking branch 'origin/dev' into feature/adaptive-res
5fd85ca
Clean up adaptive branch
533cc4d 
* Fix a nasty off-by-one error created by fixing a less
  nasty off-by-one error in output
  * Document geodesic tracer to avoid repeat problems
* Implement new refinement criterion from Zack Gelles
* Just needs a test before merge
Give the absolute error the proper units and fix an embarrassing sign…
2e05641 
… bug. Add a basic refinement regression test
Repair the thin-disk problem after new adaptive-res stuff
03a6518
@bprather
Copy link
Collaborator Author

This branch has progressed far enough to be merged I think. Quick summary:

  1. New heuristic from Zack Gelles
  2. Regression test that a suitably stringent refinement requirement produces an image with very low MSE. Note that compare.py return criterion is now MSE, it was relative flux difference for some reason.
  3. While there's still work in figuring out interpolation, the code already tracks which pixels were traced vs interpolated, so it is unlikely to need major changes
    In short this solves blocker (2) and lays a good foundation for (3). (1) will take longer and has its own bug, Slow Light Test #24

@bprather bprather changed the title WIP: Preliminary adaptive resolution Preliminary adaptive resolution May 12, 2020
@bprather bprather merged commit 9436c6f into dev May 15, 2020
@bprather bprather deleted the feature/adaptive-res branch May 15, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bprather