Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new whitelist solution #3614

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from
Open

Add a new whitelist solution #3614

wants to merge 14 commits into from

Conversation

chopin-fan
Copy link
Collaborator

@chopin-fan chopin-fan commented Sep 29, 2024

For issue #3610 .

Add *, +, - operators to BigIntValue type.

Copy link

vizipi bot commented Sep 29, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
53.85% gldeng 14 7
30.77% eanzhao 32 4
30.77% ZhangXin 32 4
30.77% jason-hoopox 12 4
30.77% 轩辕焮痕 1 4
23.08% AbigailDeng 1 3

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
...test/AElf.OS.Network.Grpc.Tests/AElf.OS.Network.Grpc.Test66.67%2 out of 3 times
test/AElf.OS.Tests/AElf.OS.Tests.csproj66.67%2 out of 3 times
...test/AElf.Kernel.TransactionPool.Tests/AElf.Kernel.Transa66.67%2 out of 3 times
test/AElf.CrossChain.Tests/AElf.CrossChain.Tests.csproj66.67%2 out of 3 times
...test/AElf.Contracts.Genesis.Tests/AElf.Contracts.Genesis.66.67%2 out of 3 times
...test/AElf.Contracts.MultiToken.Tests/AElf.Contracts.Multi66.67%2 out of 3 times
test/AElf.Kernel.Core.Tests/AElf.Kernel.Core.Tests.csproj66.67%2 out of 3 times
...test/AElf.Runtime.CSharp.Tests/AElf.Runtime.CSharp.Tests.66.67%2 out of 3 times
...test/AElf.Contracts.CrossChain.Tests/AElf.Contracts.Cross66.67%2 out of 3 times
...test/AElf.Contracts.Election.Tests/AElf.Contracts.Electio66.67%2 out of 3 times

Committed file ranks

(click to expand)
  • 84.98%[...test/AElf.Sdk.CSharp.Tests/CSharpSmartContractContextTest]
  • 82.73%[src/AElf.Runtime.CSharp.Core/ContractCodeLoadContext.cs]
  • 0.00%[test/AElf.Sdk.CSharp.Tests/ed25519_testdata.json]
  • 99.29%[test/AElf.Sdk.CSharp.Tests/AElf.Sdk.CSharp.Tests.csproj]
  • 98.92%[src/AElf.Sdk.CSharp/CSharpSmartContractContext.cs]
  • 98.52%[AElf.All.sln]
  • 0.00%[src/AElf.Sdk.CSharp.Spec/IBuiltIns.cs]
  • 20.52%[src/AElf.Sdk.CSharp.Spec/AElf.Sdk.CSharp.Spec.csproj]
  • 0.00%[src/AElf.Sdk.CSharp.Internal/AssemblyInfo.cs]
  • 79.55%[src/AElf.Sdk.CSharp/CSharpSmartContractAbstract.cs]
  • Copy link

    codecov bot commented Sep 29, 2024

    Codecov Report

    Attention: Patch coverage is 25.00000% with 75 lines in your changes missing coverage. Please review.

    Project coverage is 73.12%. Comparing base (88d4e10) to head (aa43d7b).

    Files with missing lines Patch % Lines
    src/AElf.Types/Types/BigIntValue.cs 0.00% 34 Missing ⚠️
    src/AElf.Sdk.CSharp.Internal/InternalBuiltIns.cs 17.14% 29 Missing ⚠️
    src/AElf.Sdk.CSharp/CSharpSmartContractContext.cs 40.00% 12 Missing ⚠️

    ❗ There is a different number of reports uploaded between BASE (88d4e10) and HEAD (aa43d7b). Click for more details.

    HEAD has 11 uploads less than BASE
    Flag BASE (88d4e10) HEAD (aa43d7b)
    21 10
    Additional details and impacted files

    Impacted file tree graph

    @@             Coverage Diff             @@
    ##              dev    #3614       +/-   ##
    ===========================================
    - Coverage   90.53%   73.12%   -17.42%     
    ===========================================
      Files         677      678        +1     
      Lines       26104    26197       +93     
      Branches     2353     2355        +2     
    ===========================================
    - Hits        23634    19156     -4478     
    - Misses       2355     6888     +4533     
    - Partials      115      153       +38     
    Flag Coverage Δ
    ?

    Flags with carried forward coverage won't be shown. Click here to find out more.

    Files with missing lines Coverage Δ
    ...CSharp.CodeOps/Validators/Method/ArrayValidator.cs 95.17% <100.00%> (ø)
    ...CodeOps/Validators/Whitelist/IWhitelistProvider.cs 100.00% <100.00%> (ø)
    ...Elf.Runtime.CSharp.Core/ContractCodeLoadContext.cs 100.00% <100.00%> (ø)
    src/AElf.Sdk.CSharp/CSharpSmartContractAbstract.cs 100.00% <ø> (ø)
    src/AElf.Sdk.CSharp/CSharpSmartContractContext.cs 66.92% <40.00%> (-11.84%) ⬇️
    src/AElf.Sdk.CSharp.Internal/InternalBuiltIns.cs 17.14% <17.14%> (ø)
    src/AElf.Types/Types/BigIntValue.cs 0.00% <0.00%> (-26.32%) ⬇️

    ... and 148 files with indirect coverage changes

    @@ -5,9 +5,30 @@

    namespace AElf.Types
    {

    public partial class BigIntValue : IComparable, IComparable<BigIntValue>
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Improved BigIntValue by the way, nice.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants