Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/acs404 #3523

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feature/acs404 #3523

wants to merge 4 commits into from

Conversation

zhifenglee-aelf
Copy link
Collaborator

No description provided.

@zhifenglee-aelf zhifenglee-aelf changed the base branch from dev to master February 21, 2024 00:13
Copy link

vizipi bot commented Feb 21, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00% EanCuznaivy 266 9
100.00% jason-hoopox 25 9
100.00% gldeng 19 9
100.00% ZhangXin 18 9
88.89% kaiwenzhengaelf 42 8
88.89% louis.li 25 8

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
contract/AElf.Contracts.MultiToken/TokenContract_Fees.cs80.00%4 out of 5 times
...test/AElf.Contracts.MultiToken.Tests/BVT/TokenManagementT80.00%4 out of 5 times
...test/AElf.Contracts.MultiToken.Tests/MultiTokenContractTe80.00%4 out of 5 times
...contract/AElf.Contracts.Election/ElectionContract_Elector80.00%4 out of 5 times
contract/AElf.Contracts.Profit/ProfitContract.cs80.00%4 out of 5 times
test/AElf.Contracts.Election.Tests/BVT/ElectionTests.cs80.00%4 out of 5 times
...test/AElf.Contracts.Economic.TestBase/ContractsPreparatio80.00%4 out of 5 times
...test/AElf.Contracts.EconomicSystem.Tests/BVT/TreasuryBasi80.00%4 out of 5 times
...test/AElf.Contracts.TokenConverter.Tests/TokenConverterCo80.00%4 out of 5 times
...contract/AElf.Contracts.MultiToken/TokenContractState_Cha80.00%4 out of 5 times

Committed file ranks

(click to expand)
  • 92.98%[...test/AElf.Contracts.MultiToken.Tests/BVT/NftApplicationTe]
  • 99.97%[protobuf/token_contract.proto]
  • 96.20%[...contract/AElf.Contracts.MultiToken/TokenContract_NFT_Acti]
  • 99.57%[contract/AElf.Contracts.MultiToken/TokenContract_Helper.cs]
  • 99.98%[contract/AElf.Contracts.MultiToken/TokenContract_Actions.cs]
  • 88.21%[...contract/AElf.Contracts.MultiToken/TokenContract_NFTHelpe]
  • 99.40%[contract/AElf.Contracts.MultiToken/TokenContractState.cs]
  • 98.82%[...test/AElf.Contracts.MultiToken.Tests/BVT/TokenApplication]
  • 97.44%[protobuf/token_contract_impl.proto]
  • Copy link

    codecov bot commented Feb 21, 2024

    Codecov Report

    Attention: 8 lines in your changes are missing coverage. Please review.

    Comparison is base (7541806) 90.66% compared to head (445d56a) 90.65%.

    Additional details and impacted files

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##           master    #3523      +/-   ##
    ==========================================
    - Coverage   90.66%   90.65%   -0.02%     
    ==========================================
      Files         663      663              
      Lines       25458    25480      +22     
      Branches     2285     2284       -1     
    ==========================================
    + Hits        23082    23098      +16     
    - Misses       2260     2267       +7     
    + Partials      116      115       -1     
    Files Coverage Δ
    .../AElf.Contracts.MultiToken/TokenContract_Helper.cs 84.08% <100.00%> (+0.14%) ⬆️
    ....Contracts.MultiToken/TokenContract_NFT_Actions.cs 91.78% <100.00%> (+1.36%) ⬆️
    ...lf.Contracts.MultiToken/TokenContract_NFTHelper.cs 77.77% <74.19%> (-22.23%) ⬇️

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant