Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: break down DeploySmartContract into smaller methods to improve readability #3448

Open
wants to merge 1 commit into
base: feature/deterministic-address
Choose a base branch
from

Conversation

gldeng
Copy link
Contributor

@gldeng gldeng commented Sep 21, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #3448 (7c6d5d6) into feature/deterministic-address (a705e46) will decrease coverage by 9.48%.
The diff coverage is 74.38%.

Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                        @@
##           feature/deterministic-address    #3448      +/-   ##
=================================================================
- Coverage                          90.72%   81.25%   -9.48%     
=================================================================
  Files                                663      664       +1     
  Lines                              25388    25444      +56     
  Branches                            2280     2282       +2     
=================================================================
- Hits                               23033    20674    -2359     
- Misses                              2239     4607    +2368     
- Partials                             116      163      +47     
Files Changed Coverage Δ
...ntract/AElf.Contracts.Genesis/BasicContractZero.cs 22.25% <47.61%> (-61.73%) ⬇️
contract/AElf.Contracts.Genesis/Extensions.cs 77.02% <77.02%> (ø)
...AElf.Contracts.Genesis/BasicContractZero_Helper.cs 40.00% <88.46%> (-57.03%) ⬇️

... and 125 files with indirect coverage changes

@vizipi
Copy link

vizipi bot commented Sep 21, 2023

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
66.67 % jason-hoopox 29 2
66.67 % ZhangXin 20 2
66.67 % kaiwenzhengaelf 17 2
66.67 % ssun0121 14 2
66.67 % YueZh127 2 2
66.67 % AbigailDeng 1 2

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
...test/AElf.Contracts.Genesis.Tests/GenesisContractAuthTest50.00 %52 out of 104 times
protobuf/acs0.proto49.04 %51 out of 104 times
contract/AElf.Contracts.Genesis/BasicContractZeroState.cs42.31 %44 out of 104 times

Committed file ranks

(click to expand)
  • 98.54%[contract/AElf.Contracts.Genesis/BasicContractZero_Helper.cs]
  • 99.82%[contract/AElf.Contracts.Genesis/BasicContractZero.cs]
  • 0.00%[contract/AElf.Contracts.Genesis/Extensions.cs]
  • @delete-merged-branch delete-merged-branch bot deleted the branch feature/deterministic-address September 25, 2023 10:44
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant