Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] One more code checking during the block validation if the previous code checking was failed. #3328

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

EanCuznaivy
Copy link
Contributor

The failure of previous code checking was probably due to the aelf node still in an old version. One more code checking will help this aelf node sync new blocks as expected.

@vizipi
Copy link

vizipi bot commented Sep 21, 2022

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

No other active qualified developers found to review these specific changes. You might consider involving more team members with these code segments.


Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
src/AElf.Kernel.CodeCheck/ContractCodeHashMap.cs50.00 %6 out of 12 times
...src/AElf.Kernel.CodeCheck/Application/ICheckedCodeHashPro50.00 %6 out of 12 times
src/AElf.Kernel.CodeCheck/CodeCheckAElfModule.cs50.00 %6 out of 12 times
protobuf/acs0.proto50.00 %6 out of 12 times
contract/AElf.Contracts.Genesis/BasicContractZeroState.cs41.67 %5 out of 12 times
...src/AElf.Kernel.CodeCheck/CodeCheckRequiredLogEventProces41.67 %5 out of 12 times
...src/AElf.Kernel.CodeCheck/NewIrreversibleBlockFoundEventH41.67 %5 out of 12 times
src/AElf.Kernel.CodeCheck/AElf.Kernel.CodeCheck.csproj41.67 %5 out of 12 times

Committed file ranks

(click to expand)
  • 66.78%[...src/AElf.Kernel.CodeCheck/Application/CodeCheckValidation]
  • @codecov
    Copy link

    codecov bot commented Sep 21, 2022

    Codecov Report

    Merging #3328 (032d823) into dev (248dd94) will decrease coverage by 0.00%.
    The diff coverage is 0.00%.

    Additional details and impacted files

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##              dev    #3328      +/-   ##
    ==========================================
    - Coverage   89.24%   89.23%   -0.01%     
    ==========================================
      Files         629      629              
      Lines       25154    25156       +2     
      Branches     2210     2210              
    ==========================================
      Hits        22448    22448              
    - Misses       2442     2444       +2     
      Partials      264      264              
    Impacted Files Coverage Δ
    ...deCheck/Application/CodeCheckValidationProvider.cs 0.00% <0.00%> (ø)

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants