Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): update to Node 20 and update CircleCI config #939

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix(ci): update to Node 20 and update CircleCI config #939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
orbs:
codecov: codecov/codecov@3.2.5
docker: circleci/docker@2.2.0
node: circleci/node@5.1.0
shellcheck: circleci/shellcheck@3.1.2
slack: circleci/slack@4.12.5
codecov: codecov/codecov@4.1.0
docker: circleci/docker@2.7.1
node: circleci/node@6.1.0
shellcheck: circleci/shellcheck@3.2.0
slack: circleci/slack@4.13.3
version: 2.1
jobs:
test:
docker:
- image: cimg/node:18.18.0
- image: cimg/postgres:10.22
- image: cimg/node:20.17.0
- image: cimg/postgres:16.4
environment:
POSTGRES_PASSWORD: config.test.postgres.password
parallelism: 4
Expand All @@ -30,16 +30,16 @@ jobs:
path: ~/reports
build:
docker:
- image: cimg/base:2023.09
- image: cimg/base:2024.09
resource_class: large
steps:
- checkout
- setup_remote_docker:
version: 20.10.23
version: default
- run: docker-compose -f docker/docker-compose.yml -f docker/docker-compose.dev.yml build --no-cache discounts
eslint:
docker:
- image: cimg/node:18.18.0
- image: cimg/node:20.17.0
resource_class: large
steps:
- checkout
Expand All @@ -52,23 +52,23 @@ jobs:
path: ~/reports
yamllint:
docker:
- image: cimg/python:3.11.3
- image: cimg/python:3.12.6
resource_class: large
steps:
- checkout
- run: pip install yamllint
- run: yamllint -d .yamllint.yml .
shellcheck:
docker:
- image: cimg/base:2023.05
- image: cimg/base:2024.09
resource_class: large
steps:
- checkout
- shellcheck/install
- shellcheck/check
audit:
docker:
- image: cimg/node:18.18.0
- image: cimg/node:20.17.0
resource_class: large
steps:
- checkout
Expand Down Expand Up @@ -115,12 +115,12 @@ jobs:
}
docker-build-and-push:
docker:
- image: cimg/node:18.18.0
- image: cimg/node:20.17.0
resource_class: large
steps:
- checkout
- setup_remote_docker:
version: 20.10.23
version: default
- node/install-packages
- run: npx semantic-release
- run: echo export PACKAGE_VERSION=$(node -p "require('./package.json').version") >> $BASH_ENV
Expand Down
4 changes: 2 additions & 2 deletions docker/discounts/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# FIXME use alpine
FROM node:18.18.0
FROM node:20.17.0

RUN mkdir -p /usr/app/src \
&& mkdir -p /usr/app/media \
Expand All @@ -18,7 +18,7 @@ ENV NPM_CONFIG_PREFIX=/home/node/.npm-global
ENV PATH="/home/node/.npm-global/bin:${PATH}"

# FIXME remove nodemon for production
RUN npm install -g nodemon@2.0.14 \
RUN npm install -g nodemon@3.1.4 \
&& npm install -g [email protected] \
&& npm cache clean --force \
&& npm ci
Expand Down
Loading