Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON support and fix Verinet installation #90

Closed
wants to merge 0 commits into from

Conversation

TrisCC
Copy link
Collaborator

@TrisCC TrisCC commented Jun 17, 2024

The PR looks a bit messy because I forgot to rebase the branch in my fork correctly and squashed the commits, but it will still work just fine.

Changes:

  • Add JSON support for VerificationResults: Working with csvs was fine, but to read some of the error messages from a few instances manually to inspect errors was a bit difficult. JSON is more suitable for that.
  • Fix relative import and Verinet installer: Netron had to be updated for it to work.
  • Add gitignore and fix build script: Working with vnncomp files in the same folder is sometimes desired.
  • Improve logger and json converter: Add a little indicator to see how far into the verification batch process the program is in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant