-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent FC with old LND nodes if HTLCs are in flight while closing #2907
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very sad to implement those hacky workarounds, but if it avoids force-closed channels, it's worth it! And hopefully we can get rid of those at some point 🤞
eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/ErrorHandlers.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/ErrorHandlers.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/ErrorHandlers.scala
Outdated
Show resolved
Hide resolved
inlined error messages some spelling errors fixed
check timed out on the 3rd to last check... |
Unfortunately this happens sometimes when the CI machine doesn't have enough memory available and a bitcoind instance fails to start (since our tests spin up a bunch of bitcoind instances in parallel). When that happens, I'll restart the failed build manually from github, don't worry about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This simple change will prevent an FC when a close is done while HTLCs are in flight with LND nodes older than 0.18.0