Add support for bech32m bitcoin wallets #2873
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstone
force-pushed
the
use-bech32m-wallet
branch
from
9f9774f
to
d603e95
Compare
sstone
force-pushed
the
use-bech32m-wallet
branch
from
d603e95
to
2353b24
Compare
sstone
force-pushed
the
use-bech32m-wallet
branch
2 times, most recently
from
cd2dac0
to
02c9ab2
Compare
sstone
force-pushed
the
use-bech32m-wallet
branch
from
02c9ab2
to
6f067ff
Compare
These changes allow eclair to be used with a bitcoin core wallet configured to generate bech32m (p2tr) addresses and change addresses. The wallet still needs to be able to generate bech32 (p2wpkh) addresses in some cases (support for static_remote_key for non anchor channels for example).
sstone
force-pushed
the
use-bech32m-wallet
branch
from
6f067ff
to
eb4b6c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow eclair to be used with a bitcoin core wallet configured to generate
bech32m(p2tr) addresses and change addresses, which is not possible currently because there are a few place wherep2wpkhis "hardcoded" (i.e. we implicitly assume that wallet addresses arep2wpkhaddresses). We also handle the special case where eclair manages bitcoin core's private keys.The wallet still needs to be able to generate
bech32(p2wpkh) addresses in some cases (support forstatic_remote_keyfor non anchor channels for example).