Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kanela-agent version in starter scripts to match the version set in pom.xml #2730

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

sstone
Copy link
Member

@sstone sstone commented Aug 28, 2023

It will fix the error we get when we start with -with-kanela

@sstone sstone requested a review from pm47 August 28, 2023 17:25
t-bast
t-bast previously approved these changes Aug 28, 2023
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I didn't know we had an explicit version in the scripts...
This isn't very robust, we'll probably forget to update it every time :/

@pm47
Copy link
Member

pm47 commented Aug 28, 2023

Let's add a warning in the pom?

@sstone
Copy link
Member Author

sstone commented Aug 28, 2023

I added a comment to remind us to update both pom.xml and our scripts.

@codecov-commenter
Copy link

Codecov Report

Merging #2730 (c56e7d3) into master (3547f87) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head c56e7d3 differs from pull request most recent head 75274c2. Consider uploading reports for the commit 75274c2 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #2730      +/-   ##
==========================================
+ Coverage   85.87%   85.90%   +0.02%     
==========================================
  Files         215      215              
  Lines       17823    17823              
  Branches      761      761              
==========================================
+ Hits        15306    15311       +5     
+ Misses       2517     2512       -5     

see 2 files with indirect coverage changes

@sstone sstone merged commit 8d42052 into master Aug 29, 2023
1 check passed
@sstone sstone deleted the update-kanela-agent branch August 29, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants