Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling Actually Additions Item Laser Particles #560

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

WaitingIdly
Copy link
Contributor

changes in this PR:

  • adjust Actually Additions files to be placed in separate folders
  • adds a somewhat complex config option to control when particles for the Actually Additions Item Laser stops rendering Particles from transferring items. (default: -1)

created because looking at a large laser network basically disables fps, and there was no way to fix this. having it be a simple boolean "on/off" is undesirable as it does not allow the user to change it while in-game.

Copy link

what-the-diff bot commented Oct 1, 2024

PR Summary

  • Enhanced Readme Documentation
    The README.md has been updated with a detailed explanation of the new feature: "Item Laser Particles Graphics". It comprehensively elaborates on the settings for controlling the visuals of item laser particles.

  • User Control Over Graphic Settings
    The UTConfigMods.java file has been updated to include a fresh configuration option named utItemLaserParticlesGraphics. This improvement empowers users by allowing them to manipulate the graphic settings pertaining to the item laser particles.

  • Adaptive Particle Visibility
    Changes have been made to UTMixinLoader.java to allow dynamic loading of mixins relating to item particles. This is conditional, based on the newly introduced user setting, offering users more personalized control over particle visibility.

  • Clarifying Class Names
    The names of several mixin classes have been altered to better communicate their function. This pertains to classes that work on enhancements related to duplication resolution and laser relay upgrades.

  • Improved Particle Conditions Management
    Created a new mixin: UTTileEntityItemViewerMixin. This has boosted the system's ability to handle item particle settings. This improvement ensures that particles are generated only under specific, predefined conditions, enhancing system efficiency.

  • Refreshed Configuration Files
    To match the refactored package structures for duplication fixes and item particle configuration, the JSON configuration files for new and renamed mixins have been updated. This contributes to consistency and clarity within the codebase.

@ACGaming ACGaming merged commit 1a14519 into ACGaming:main Oct 1, 2024
1 check passed
@WaitingIdly WaitingIdly deleted the aa-item-laser branch October 1, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants