Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InControl mixin to fix various stat doubling #557

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

jchung01
Copy link
Contributor

@jchung01 jchung01 commented Sep 25, 2024

Fixes onjoin rules in spawn.json and summonaid.json causing repeated stat modifications if using the health/speed/damage actions. Mixes into McJtyTools, which is an embedded library of InControl by jar-in-jar, so added a Maven repo to add it to the dev environment separately.
This implements McJtyMods/McJtyTools@9cd16506, which was never included in an official InControl version.
Should fix McJtyMods/InControl#223, among many of the other duplicate issues.

Copy link

what-the-diff bot commented Sep 25, 2024

PR Summary

  • Updated README.md documentation
    The README.md file now includes a newly introduced fix related to the "In Control!" mod, specifically concerning spawn rules.

  • Added Dependencies
    New dependencies for "mcjtytools" and "incontrol" have been added to the dependencies.gradle file.

  • Introduced Debug Flag
    A debug flag for "incontrol" has been added to the gradle.properties file for easier debugging.

  • New Maven Repository
    A new Maven repository for "McJty Tools" is added in repositories.gradle.

  • New Configuration Category
    A new configuration category for the mod "In Control!" has been introduced in the UTConfigMods.java file.

  • Spawn Rule Stats Toggle
    Created a new InControlCategory class that includes a toggle for controlling the "Spawn Rule Stats Fix".

  • Managing Tag-related Attributes
    Implementation of mixin functionality to manage attributes related to health, speed, and damage checks in UTRuleBaseMixin.java and UTSummonAidRuleMixin.java.

  • New Attributes Enum
    A new Attributes enum for health, speed, and damage management has been introduced in the Attributes.java file.

  • Updated Language Entry
    A new language entry for "In Control!" has been added to the language file, en_us.lang.

  • Mixin Configuration
    A new mixin configuration "incontrol" has been introduced in mixins.mods.incontrol.json.

@ACGaming ACGaming merged commit 9af0525 into ACGaming:main Sep 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants