Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weaken Wither Structure Requirements #464

Merged
merged 1 commit into from
May 12, 2024
Merged

Conversation

WaitingIdly
Copy link
Contributor

changes in this PR:

  • made is so the wither pattern applies '~', unused -> true instead of BlockWorldState.hasState(BlockMaterialMatcher.forMaterial(Material.AIR)), meaning any blocks will match it, not just AIR.
  • made is so forming the wither will not replace the side bottom blocks.
  • tied to a single config option (default: false)

Copy link

what-the-diff bot commented May 11, 2024

PR Summary

  • Introduction of Weaker Wither Structure Requirements
    This new feature gives users more flexibility when creating 'Withers' by allowing non-air blocks to be used in the bottom corners of a structure. This results in a convenient user experience.

  • Adjustments to UTConfigTweaks.java
    This file has been updated with a new boolean variable utWitherPlacement. This variable is specifically programmed to support our new feature of weakening Wither structure requirements, essentially making it an on/off switch for this feature in our codebase.

  • Addition of UTWitherFormationMixin.java
    This new file has the mixin for modifying the rules of how the wither is formed. This change makes our new feature - Weaken Wither Structure Requirements, functional.

  • Inclusion of mixins.tweaks.blocks.witherstructure.json
    To perfectly sync our wither structure changes, we added this new configuration file. It enables us to properly configure the desired changes in Wither structure according to our requirements. Without this configuration, implementation of our new feature would've been problematic.

@ACGaming ACGaming merged commit 79bfad6 into ACGaming:main May 12, 2024
1 check passed
@WaitingIdly WaitingIdly deleted the wither-air branch May 12, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants