make Extra Utilities 2 Machine Block drops mutable #432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when breaking Extra Utilities 2 Machines, they return an ImmutableList. this causes issues for anything attempting to remove entries from the list, causing an
UnsupportedOperationException
. in addition to other, unknown things, this impacts the EnderIO Direct upgrade (both upgrade & Tinkers modifier) and the Astral Sorcery Scorching enchantment.here is the issue reported to EnderIO: SleepyTrousers/EnderIO-1.5-1.12#5360
heres the issue with the Direct upgrade and Astral Sorcery Scorching enchantment (both things modifying the list) being reported elsewhere: Divine-Journey-2/Divine-Journey-2#1138, Divine-Journey-2/Divine-Journey-2#345