Merge pull request #150 from MatthiasSachs/ms/fix-redefinition

fixed redefinition of dstate_type and removed unused declarations
ACEsuit · Nov 29, 2024 · 3db4768 · 3db4768
2 parents 147b005 + 6fa0fe2
commit 3db4768
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 10 deletions.
diff --git a/src/properties.jl b/src/properties.jl
@@ -488,7 +488,7 @@ using ACE.Wigner: wigner_D_indices
 # ∫_{SO3} D^{ll}_{μμmm} D^*(Q) e^t dQ -> 2L+1 column vector
 function vec_cou_coe(rotc::Rot3DCoeffs{T},
 					      l::Integer, m::Integer, μ::Integer,
-					      L::Integer, t::Integer) where {T,N}
+					      L::Integer, t::Integer) where {T}
 	@assert 0 < t <= 2L+1
 	D = wigner_D_indices(L)'   # Dt = D[:,t]  -->  # D^* ⋅ e^t
 	LL = SA[l, L]
@@ -585,7 +585,7 @@ end
 SphericalMatrix{L1, L2, LEN1, LEN2, T, LL}()  where {L1, L2, LEN1, LEN2, T, LL} =
       SphericalMatrix( zero(SMatrix{LEN1, LEN2, T}), Val{L1}(), Val{L2}() )
 
-SphericalMatrix{L1, L2, LEN1, LEN2, T}()  where {L1, L2, LEN1, LEN2, T, LL} =
+SphericalMatrix{L1, L2, LEN1, LEN2, T}()  where {L1, L2, LEN1, LEN2, T} =
 		SphericalMatrix( zero(SMatrix{LEN1, LEN2, T}), Val{L1}(), Val{L2}() )
 
 function filter(φ::SphericalMatrix, grp::O3, b::Array)

diff --git a/src/states.jl b/src/states.jl
@@ -190,13 +190,6 @@ end
 end
 
 
-@generated function dstate_type(X::TX)  where {TX <: State}
-   CSYMS = _ctssyms(TX) 
-   quote
-      typeof( DState( select(_x(X), $CSYMS) ) )
-   end
-end
-
 # -------------------
 
 # the next variant of dstate_type is used to potentially extend 

diff --git a/src/utils/pools.jl b/src/utils/pools.jl
@@ -124,7 +124,7 @@ Base.size(pA::GenCachedArray, args...) = size(pA.A, args...)
 Base.parent(pA::GenCachedArray) = pA.A
 
 
-function GenArrayCache() where {T} 
+function GenArrayCache()
    nt = nthreads()
    vecs = [ Stack{Vector{UInt8}}() for _=1:nt ]
    return GenArrayCache(vecs)