Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New preview workflow to work on external forks #126

Merged
merged 6 commits into from
Oct 7, 2022
Merged

Conversation

ccarouge
Copy link
Contributor

@ccarouge ccarouge commented Oct 7, 2022

ACCESS Community Hive

Thank you for submitting a pull request to the ACCESS Hive Project.

Description

Please include a brief summary of the change and list the issues that are fixed.
Please also include relevant motivation and context.

You can link issues by using a supported keyword in the pull request's description or in a commit message:

Fixes #121

Based on https://securitylab.github.com/research/github-actions-preventing-pwn-requests/, we split the preview workflow in 2 steps: the first builds the site securely and the second deploys the site preview.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue, e.g. dead links)

Checklist:

  • The new content is accessible and located in the appropriate section.
  • I have checked my code/text and corrected any misspellings

Please tag the reviewers team in a comment below by prepending an @ in front of ACCESS-Hive/reviewers when ready.

First step builds the site and is triggered by pull_request

Second step deploys the site and is triggered by workflow_run
@ccarouge ccarouge requested a review from rbeucher October 7, 2022 00:25
@ccarouge
Copy link
Contributor Author

ccarouge commented Oct 7, 2022

It's normal that a preview is not built. The workflow_run steps runs in the context of the main branch and there is no such step yet on that branch. So only the first part of the workflow is run since it's triggered by pull_request which runs within the context of the pull request merge.

@rbeucher rbeucher merged commit a387b4d into main Oct 7, 2022
@ccarouge ccarouge deleted the ccarouge/issue121 branch October 12, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR preview not building for members without write access
2 participants