Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class #160

Merged
merged 68 commits into from
Aug 16, 2024
Merged

Class #160

merged 68 commits into from
Aug 16, 2024

Conversation

paolap
Copy link
Collaborator

@paolap paolap commented Jul 24, 2024

This branch has a lot of updates.

  1. workflows to run tests are now working, setup for installing has been updated too Reviewing github actions and generally package install setup #162
  2. move to using classes for file pattern, variables as read fom output files and mapped variables see
  3. added "intake" command to generate intake catalogues for raw file output. allowing creation of intake catalogues via mopdb varlist #149
    Point 2-3 included re-organising mopdb code and template and intake commands include the varlist step. re-organise mopdb_utils.py #158 (possibly more can be done in braking down single functions so I leave this open for the moment)
  4. conda setup it's nearly ready, needs to be tested steps listed in set up conda #87 are completed

@paolap
Copy link
Collaborator Author

paolap commented Aug 15, 2024

@greensh16 I made a lot of progress on the tidying up of the code, also following "ruff" linting.
The tests are now all working, there's not many yet, but we can always add them and I updated the setup so now use pyproject.toml .
Also the workflows are now working, will need probably to fix the conda as it didn't run with this last push, but once that is done this should be ready.
I think we can at least merge but then we should make sure this work on a smaller subset/subsets for as many actual examples we have. If you don't have time is fine, I can try that with Zoe and/or Seb data, just let me know.

@paolap paolap merged commit c071084 into prerelease Aug 16, 2024
6 checks passed
@paolap paolap deleted the class branch October 31, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant