-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: addApplicationDelegate unavailable in iOS #228
Conversation
Ooh! This looks very nice. I tried to work around this by using some |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 73 73
=========================================
Hits 73 73 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this!
I'd love to hear some more reasoning about your approach in comparison to an available check. Mostly to learn a bit more about iOS!
Also could you possibly add the pod spec adjustments needed for Interactivity to the example pod file? I noticed that this way the Integration Test Would fail without adjustments so it would be a great check
target 'YourWidgetExtension' do
use_frameworks!
use_modular_headers!
pod 'home_widget', :path => '.symlinks/plugins/home_widget/ios'
end
@armandsLa Do you still have time to finish this off? |
Sorry for the late response, I've been very busy lately. I've made changes to the Podfile as requested. I moved every target to the root level and added the necessary configurations. Previously, the targets were nested, which I had never seen before. Usually, every target is at the root level, and optionally, a |
Had to make some adjustments to the Podfile in order to have integration tests pass. The nesting seems to be important to work correctly. Given that the |
I'm proposing a simple fix to avoid errors caused by
NS_EXTENSION_UNAVAILABLE_IOS
when addinghome_widget
to the widget target. This fix usesperformSelector
to bypass theNS_EXTENSION_UNAVAILABLE_IOS
macro. It might not be ideal, but it works and is very simple.