Update googletest, cmake and cleanup build variables #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
9prady9
commented
Mar 4, 2019
9prady9
commented
- Moved github templates to .github folder
- Replaced chrome/googletest with googletest/googltest
- Refactored cmake scripts to modern cmake syntax
- Increased minimum required CMake version to 3.12.4
- Cleanup documentation generation cmake script
* Moved github templates to .github folder * Replaced chrome/googletest with googletest/googltest * Refactored cmake scripts to modern cmake syntax * Increased minimum required CMake version to 3.12.3 * Cleanup documentation generation cmake script
|
this is helpful for me... thanks for the update. i have been facing problems to compile unittests when i moved gtest repo to github ... https://github.com/acrlakshman/gradient-augmented-levelset-cuda/pull/3/files (private repo, for which I sent you an invite). |
|
Coveralls is still working correctly for some reason. I am checking it now. |
9prady9
added a commit
that referenced
this pull request
Feb 21, 2020
* Update googletest, cmake and cleanup build variables * Moved github templates to .github folder * Replaced chrome/googletest with googletest/googltest * Refactored cmake scripts to modern cmake syntax * Increased minimum required CMake version to 3.12.3 * Cleanup documentation generation cmake script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.