Read write obj #33
Closed
Read write obj #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* referencing #25, #26 * Rewrote some basic datastructures [e.g. GeometryData]. * Read function for OBJ format completed with the help of tinyobjloader. * Write function for OBJ format completed with the help of tinyobjloader. * Minor cleanups. * Rewrote some components to adhere to Google C++ style guide. * Submitting this patch to receive any comments while WIP. Signed-off-by: Lakshman Anumolu <[email protected]>
Also fixed function naming style in vectors.hpp
* Made end() a virtual function in Vec classes. Signed-off-by: Lakshman Anumolu <[email protected]>
* removed obj subfolder * obj tests working Signed-off-by: Lakshman Anumolu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please pick a relevant checklist(remove others) and make sure to finish & check all items for the PR.
Feature Completeness: