Test cases updated #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added binary STL file for cube (obtained by converting cube_ascii.stl) using convertSTL (https://github.com/cmpolis/convertSTL) * Updated test cases accordingly * Helper functions are added to members in mesh_io_defines.hpp Signed-off-by: Lakshman Anumolu <[email protected]>
| Vec4((T)0, (T)0, (T)0, (T)0); | ||
| } | ||
|
|
||
| bool equal(Vec4& pVec4) { |
There was a problem hiding this comment.
overload == and != operators instead of using a function. Also, since you have many other member functions, i think we can promote this to a proper class with proper constructors, setters, getters, destructors and other operator overloads.
Signed-off-by: Lakshman Anumolu <[email protected]>
|
Accepting it now, will fix the inl file thing along with my changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using convertSTL (https://github.com/cmpolis/convertSTL)
Signed-off-by: Lakshman Anumolu [email protected]