Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”จ Refactor/#75 : qr ์ƒ์„ฑ์šฉ ์ด๋ฏธ์ง€ file -> url๋กœ ๋ณ€๊ฒฝ #76

Merged
merged 1 commit into from
Nov 22, 2024
Merged

๐Ÿ”จ Refactor/#75 : qr ์ƒ์„ฑ์šฉ ์ด๋ฏธ์ง€ file -> url๋กœ ๋ณ€๊ฒฝ #76

merged 1 commit into from
Nov 22, 2024

Conversation

bianbbc87
Copy link
Collaborator

Related issue ๐Ÿ› 

closed #75

์–ด๋–ค ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์žˆ์—ˆ๋‚˜์š”?

  • ๐Ÿž BugFix Something isn't working
  • ๐Ÿ’ป CrossBrowsing Browser compatibility
  • ๐ŸŒ Deploy Deploy
  • ๐ŸŽจ Design Markup & styling
  • ๐Ÿ“ƒ Docs Documentation writing and editing (README.md, etc.)
  • โœจ Feature Feature
  • ๐Ÿ”จ Refactor Code refactoring
  • โš™๏ธ Setting Development environment setup
  • โœ… Test Test related (storybook, jest, etc.)

CheckPoint โœ…

PR์ด ๋‹ค์Œ ์š”๊ตฌ ์‚ฌํ•ญ์„ ์ถฉ์กฑํ•˜๋Š”์ง€ ํ™•์ธํ•˜์„ธ์š”.

  • PR ์ปจ๋ฒค์…˜์— ๋งž๊ฒŒ ์ž‘์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค. (ํ•„์ˆ˜)
  • Docker Container ํ™˜๊ฒฝ์œผ๋กœ ๋ณ€๊ฒฝ ์‚ฌํ•ญ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ๋ฅผ ํ–ˆ์Šต๋‹ˆ๋‹ค.(๋ฒ„๊ทธ ์ˆ˜์ •/๊ธฐ๋Šฅ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ). (ํ•„์ˆ˜)
  • Feature์˜ ๊ฒฝ์šฐ, API ๋ฌธ์„œ ์—…๋ฐ์ดํŠธ๋ฅผ ์™„๋ฃŒํ–ˆ์Šต๋‹ˆ๋‹ค. (์„ ํƒ)
  • BugFix์˜ ๊ฒฝ์šฐ, ๋ฒ„๊ทธ์˜ ์›์ธ์„ ํŒŒ์•…ํ•˜์˜€์Šต๋‹ˆ๋‹ค. (์„ ํƒ)

Work Description โœ๏ธ

  • qr ์ƒ์„ฑ์šฉ ์ด๋ฏธ์ง€ file -> url๋กœ ๋ณ€๊ฒฝ

Uncompleted Tasks ๐Ÿ˜…

  • Task1

To Reviewers ๐Ÿ“ข

@bianbbc87 bianbbc87 added ๐Ÿ”จ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง bianbbc87 assigned to bianbbc87 labels Nov 22, 2024
@bianbbc87 bianbbc87 self-assigned this Nov 22, 2024
@bianbbc87 bianbbc87 merged commit 502f01a into dev Nov 22, 2024
2 checks passed
@bianbbc87 bianbbc87 deleted the refactor/#75 branch November 22, 2024 16:49
dongkyeomjang pushed a commit that referenced this pull request Nov 22, 2024
@bianbbc87
โ™ป๏ธ refactor/#75 : qr ์ƒ์„ฑ์šฉ ์ด๋ฏธ์ง€ file -> url๋กœ ๋ณ€๊ฒฝ (#76)
70b787f 
Signed-off-by: EunJiJung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongkyeomjang dongkyeomjang Awaiting requested review from dongkyeomjang dongkyeomjang is a code owner

Assignees

@bianbbc87 bianbbc87

Labels
bianbbc87 assigned to bianbbc87 ๐Ÿ”จ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง
Projects
None yet
Milestone
No milestone
1 participant
@bianbbc87