Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker): add edk2 containers between 2023-02 and 2024-05 #407

Merged
merged 3 commits into from
Nov 18, 2024
Merged

feat(docker): add edk2 containers between 2023-02 and 2024-05 #407

merged 3 commits into from
Nov 18, 2024

Conversation

AtomicFS
Copy link
Collaborator

@AtomicFS AtomicFS commented Nov 14, 2024 •
edited
Loading

I hope that the GCC_VERSION values are correct.

@github-actions github-actions bot added feature New feature or request docker docker related labels Nov 14, 2024
@AtomicFS AtomicFS added the high_priority Very important label Nov 14, 2024
@AtomicFS
Copy link
Collaborator Author

Once the #409 is merged and CI clears up a bit I will rebase this and bump the GCC version a bit to see if it will work.

@AtomicFS AtomicFS marked this pull request as ready for review November 14, 2024 19:03
@AtomicFS AtomicFS requested a review from MDr164 as a code owner November 14, 2024 19:03
@github-actions github-actions bot enabled auto-merge November 14, 2024 19:03
@AtomicFS AtomicFS force-pushed the feat/edk2-202408-dev branch 4 times, most recently from 0383315 to a7567c6 Compare November 18, 2024 10:27
@AtomicFS
Copy link
Collaborator Author

AtomicFS commented Nov 18, 2024 •
edited
Loading

@benjamindoron Hey, I have backported a patch from edk2-stable202408.01 to older edk2 releases. Could you maybe get it into upstream edk2? (Get upstream edk2 to make patched releases)

@AtomicFS AtomicFS force-pushed the feat/edk2-202408-dev branch from a7567c6 to 1a48840 Compare November 18, 2024 12:17
@github-actions github-actions bot added the testing Testing related label Nov 18, 2024
@AtomicFS AtomicFS force-pushed the feat/edk2-202408-dev branch from 1a48840 to 4498b22 Compare November 18, 2024 13:45
@AtomicFS AtomicFS force-pushed the feat/edk2-202408-dev branch from 4498b22 to b3dd958 Compare November 18, 2024 14:20
@AtomicFS
Copy link
Collaborator Author

@MDr164 ready for review now

MDr164
MDr164 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@MDr164 MDr164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDK2 sure is fun to debug it seems

@github-actions github-actions bot added this pull request to the merge queue Nov 18, 2024
@AtomicFS AtomicFS removed this pull request from the merge queue due to a manual request Nov 18, 2024
@AtomicFS AtomicFS added this pull request to the merge queue Nov 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 18, 2024
@AtomicFS AtomicFS added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 5e01648 Nov 18, 2024
103 checks passed
@AtomicFS AtomicFS deleted the feat/edk2-202408-dev branch November 18, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDr164 MDr164 MDr164 approved these changes

Assignees
No one assigned
Labels
docker docker related feature New feature or request high_priority Very important module/edk2 testing Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AtomicFS @MDr164