Refactor codebase

app.js

@@ -33,12 +33,12 @@ app.use('/', indexRouter);
 app.use('/users', usersRouter);
 
 // catch 404 and forward to error handler
-app.use(function(req, res, next) {
+app.use(function(next) {
   next(createError(404));
 });
 
 // error handler
-app.use(function(err, req, res, next) {
+app.use(function(err, req, res) {
   // set locals, only providing error in development
   res.locals.message = err.message;
   res.locals.error = req.app.get('env') === 'development' ? err : {};

controllers/stellar/createAccount.js

@@ -2,12 +2,11 @@ var StellarSdk = require('stellar-sdk');
 StellarSdk.Network.useTestNetwork();
 var server = new StellarSdk.Server('https://horizon-testnet.stellar.org');
 
-exports.createAccount = function(req, res, next){
+exports.createAccount = function(){
 
     var pair = StellarSdk.Keypair.random();
 
     pair.secret();
-    console.log(pair.secret());
     pair.publicKey();
     var request = require('request');
     request.get({

controllers/stellar/getBalance.js

@@ -1,8 +1,7 @@
 var StellarSdk = require('stellar-sdk');
 StellarSdk.Network.useTestNetwork();
-var server = new StellarSdk.Server('https://horizon-testnet.stellar.org');
 
-exports.getBalance = function (req, res, next) {
+exports.getBalance = function (req, res) {
     var publicKey = req.params.publicKey
 
     var server = new StellarSdk.Server('https://horizon-testnet.stellar.org');
@@ -18,7 +17,6 @@ exports.getBalance = function (req, res, next) {
                 Balance: balance.balance
             });
         });
-        console.log(arr)
         res.send({
         "publicKey": publicKey,
         "assets": arr

routes/index.js

@@ -2,7 +2,7 @@ var express = require('express');
 var router = express.Router();
 
 /* GET home page. */
-router.get('/', function(req, res, next) {
+router.get('/', function(res) {
   res.render('index', { title: 'Express' });
 });
 

routes/users.js

@@ -5,7 +5,7 @@ var router = express.Router();
 var User = require('../models/user');
 var createAccount = require('../controllers/stellar/createAccount');
 
-router.post('/signup', function(req, res, next){
+router.post('/signup', function(req, res){
 
   var user = new User({
     firstName: req.body.fname,
@@ -22,7 +22,7 @@ router.post('/signup', function(req, res, next){
     return res.status(201).json(doc);
   })
 
-  promise.catch(function(err){
+  promise.catch(function(){
     return res.status(501).json({message: 'Error registering user.'})
   })