Solving code smells #277
Open
Solving code smells #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainUee
commented
Nov 28, 2024
rainUee
commented
- extract method 提取公共方法
- introduce explaining variable 引入解释变量
- rename getJSONs to exportData and getDateFromRepository
- move the method pushArticleToRhy to B3ArticlePusher
- extract AbstractB3EventListener class
88250
requested changes
Dec 1, 2024
| * @version 1.0.0.1, Nov 27, 2024 | ||
| * @since 4.4.0 | ||
| */ | ||
| public abstract class AbstractB3EventListener extends AbstractEventListener<JSONObject> { |
There was a problem hiding this comment.
事件处理器是故意分开实现的，不进行抽象提取，因为之前考虑到可能较为易变。
| @@ -71,7 +71,11 @@ public static boolean invalidUserName(final String name) { | |||
| char c; | |||
| for (int i = 0; i < length; i++) { | |||
| c = name.charAt(i); | |||
| if (('a' <= c && c <= 'z') || ('A' <= c && c <= 'Z') || ('0' <= c && c <= '9') || '-' == c) { | |||
| * @version 1.0.0.1, Nov 27, 2023 | ||
| * @since 4.4.0 | ||
| */ | ||
| public class B3ArticlePusher { |
| @@ -520,47 +520,47 @@ public JSONObject exportHexoMDs() { | |||
| /** | |||
| * Gets all data as JSON format. | |||
| */ | |||
| public JSONObject getJSONs() { | |||
| public JSONObject exportData() { | |||
| ret.put(User.USERS, users); | ||
| return ret; | ||
| } | ||
|
|
||
| private JSONArray getJSONs(final Repository repository) { | ||
| private JSONArray getDataFromRepository(final Repository repository) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.