Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(node.js): update workflow #138

Merged
merged 1 commit into from
Nov 18, 2024
Merged

ci(node.js): update workflow #138

merged 1 commit into from
Nov 18, 2024

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Nov 18, 2024

This PR:

  • Removes Git credentials/SSH keys after checkout as a security precaution by setting persist-credentials to false. They are not used after the initial checkout, and this stops them from accidentally leaking through a script
  • Declares the minimum permissions for the workflow to run at the job level, following principle of least privilege; see related GitHub security post

@75lb 75lb merged commit fdb7af8 into 75lb:master Nov 18, 2024
14 checks passed
@75lb
Copy link
Owner

75lb commented Nov 18, 2024

thanks 👍

@Fdawgs Fdawgs deleted the patch-1 branch November 18, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants