Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(selector): cell range selector was not working when at bottom #331

Merged
merged 5 commits into from
Feb 6, 2019
Merged

fix(selector): cell range selector was not working when at bottom #331

merged 5 commits into from
Feb 6, 2019

Commits on Feb 2, 2019

  1. fix(selector): cell range selector was not working when at bottom 

    - the issue was that if user open the example "example-frozen-columns-and-rows-spreadsheet.html" and he scrolls completely at the bottom of the frozen grid (bottom right) and try to select a cell range, it was not selecting properly
    @ghiscoding
    ghiscoding committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    69c7c5a View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2019

  1. fix(selector): cell range selector work with frozen and regular grid

    Ghislain Beaulac authored and Ghislain Beaulac committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    edd52cf View commit details
    Browse the repository at this point in the history

  2. refactor(selector): simplify the code and fix indentation and format

    Ghislain Beaulac authored and Ghislain Beaulac committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    e2d2be9 View commit details
    Browse the repository at this point in the history

  3. refactor(selector): remove else condition but keep regular if

    Ghislain Beaulac authored and Ghislain Beaulac committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    71ece1d View commit details
    Browse the repository at this point in the history

  4. refactor(selector): change code as per comment in PR

    Ghislain Beaulac authored and Ghislain Beaulac committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    512f704 View commit details
    Browse the repository at this point in the history