Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/frozen grid closes request #26 #311

Merged
merged 57 commits into from
Dec 23, 2018
Merged

Feature/frozen grid closes request #26 #311

merged 57 commits into from
Dec 23, 2018

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented Dec 22, 2018

Closes #26

ghiscoding and others added 30 commits May 14, 2018 22:09
- fixed grid menu, accordion, select2 editor
- when using checkbox selector as a single row selection, we need a way to hide the "Select All" checkbox
- also added getOptions/setOptions to dynamically change options on the fly
- exposing the init() function helps dealing with i18n translation without losing any Slick.Event attached like onColumnsChanged
JS and HTML are text files, so they should be checked be CRLF for Windows and LF for Linux

slick.grid.js was in CRLF
as per commit #b2459b9905e0a3597ee00148982b1fd172c29a1a

JS and HTML are text files, so they should be checked be CRLF for Windows and LF for Linux

slick.grid.js was in CRLF
and remove grid:self spec from all trigger calls arg lists as it is added in in the trigger function

as per commit 93f043f
- add a way to show the Checkbox Selector (select all) inside the Header Row (aka Filter row) via a new flag boolean "showInFilterHeaderRow" false by defaults
- keep previous behavior of showing Checkbox Select in the Column Header Title Row, via a new flag "showInColumnTitleRow", true by default
- both flags can be used (and tested) together, but most often used separately
- also added Font-Awesome checkbox icons to demo
- to be consistent with all other flags, the 2 new flags are
   - hideInColumnTitleRow: false by default
   - hideInFilterHeaderRow: true by default
* feat(RowDetail): add 2x new subscribe methods & fixed multiple issues
…256)

* refactor: Sort and add trailing newline to .npmignore
   - misc: Exclude tests and examples from npm package
- because the notify is now in updateGroupBy(), the notify in clearDroppedGroups() becomes redundant is unnecessary
- this helps in knowing who caller the update action and user can do certain thing accordingly with this new info
* row detail view - provide alternative calculation
The function `calculateOutOfRangeViews()` is somehow complex and doesn't work correctly on my side, however a much simpler version always work for me and I'm providing it as an alternative calculation method that can be enabled by a new flag "useSimpleViewportCalc" (which is disabled by default to keep previous behavior).

* row detail, fix rendered count calculation

* row detail, switch to using RowId instead of RowIndex
- the RowIndex can be problematic when user does filtering, the rowIndex is then offset, while if we use the rowId (id of the row datacontext object) this is always valid for calculation
- without the fix, if 2 grids exists in the same page and 1 has header row showing, and the 2nd grid is not, 1 grid will affect the other. The fix is to use the grid UID to avoid such problems.
if true don't set x-overflow to hidden
as per commit 044b31e
- fixed explicit initialization example by css position
- instead of using jquery directly, we need to use the grid function to toggle pre-header
@ghiscoding
Copy link
Collaborator Author

@6pac
This is it, the PR for this major feature that we have all been waiting for.. the Frozen Column feature.
I tested everything, all 62 examples, also tested against my repos. Everything was resolved.

I know it's a big one, but let me know if there's something you want to know about.
Thanks

@ghiscoding ghiscoding changed the title Feature/frozen grid Feature/frozen grid closes request #26 Dec 22, 2018
@6pac
Copy link
Owner

6pac commented Dec 22, 2018

A huge thanks to you @ghiscoding , this was a mammoth task. Props to all the other testers and contibutors as well, notably you @ingodjango.
I think making it version 2.4.0 is the go, since this should not be a breaking change, though it will be a major upgrade.
If that's good I'll pull and do the release. No need to change the filename, I'll just add a warning about 2.4.x so people can choose to stick with 2.3 for a while if they don't need the pinned cols feature.

@ghiscoding
Copy link
Collaborator Author

ghiscoding commented Dec 22, 2018

Indeed a very lengthy feature, and yes thanks to @ingodjango which got me back into finishing it :)
I'm good with the 2.4 release.

I'm already starting to create an example with my repos, looking good so far.

@6pac 6pac merged commit 1263660 into master Dec 23, 2018
@ghiscoding
Copy link
Collaborator Author

ghiscoding commented Dec 23, 2018

@6pac
Have you pushed on NPM?
I still see the previous version 2.4.0 there... also wasn't the version 2.4.0 an old version that you published by mistake which NPM didn't want to delete? If so, we might need a 2.4.1

Yeah I see the older version 2.4.0 on NPM mistake (it's 10 months old), would you be able to push 2.4.1 to get rid of that old one?

@6pac
Copy link
Owner

6pac commented Dec 23, 2018

Damn. OK.

@ghiscoding
Copy link
Collaborator Author

@6pac
Thanks for the quick push, it's live and it's awesome...

Now it's holiday time...
Merry Christmas and enjoy the time with your family :)

@ghiscoding ghiscoding deleted the feature/frozen-grid branch February 1, 2019 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants