Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

artbio ❤️ Eco #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

artbio ❤️ Eco #56

wants to merge 2 commits into from

Conversation

drosofff
Copy link

Please find a modest contribution to the xls2tab_R tool

  • use conda r-readxl=1.3.1
  • no need for specifying R dependency
  • Add another test
  • signal that xls input has not been tested
  • minor linting of R script

@yvanlebras
Copy link
Contributor

Thank you so much Christophe! Hope all is doing well on you side! @ColineRoyaux can you check it and move to galaxyecology repo?

@@ -0,0 +1 @@
{"version": "0.1", "tests": [{"id": "functional.test_toolbox.TestForTool_xls2tab_R.test_tool_000000", "has_data": true, "data": {"tool_id": "xls2tab_R", "tool_version": "0.2", "test_index": 0, "time_seconds": 21.413196802139282, "inputs": {"input1": {"src": "hda", "id": "2891970512fa2d5a"}, "sheet": "data"}, "job": {"command_line": "Rscript '/home/chris/.planemo/planemo_tmp_nu4hmbtd/xls2tab.R' '/tmp/tmp1jl_0anm/files/d/1/5/dataset_d15219d6-57f9-4127-ad92-0ac554b5bc65.dat' 'data' '/tmp/tmp1jl_0anm/files/7/1/4/dataset_7142118d-bc03-4a86-a84c-82f86d23b201.dat'", "command_version": "", "create_time": "2021-04-22T22:49:16.884029", "exit_code": 0, "external_id": "24349", "galaxy_version": "20.01", "history_id": "2891970512fa2d5a", "id": "5729865256bc2525", "inputs": {"input1": {"id": "2891970512fa2d5a", "src": "hda", "uuid": "d15219d6-57f9-4127-ad92-0ac554b5bc65"}}, "job_messages": [], "job_metrics": [], "job_stderr": "", "job_stdout": "", "model_class": "Job", "outputs": {"output": {"id": "5729865256bc2525", "src": "hda", "uuid": "7142118d-bc03-4a86-a84c-82f86d23b201"}}, "params": {"__input_ext": "\"xlsx\"", "chromInfo": "\"/home/chris/galaxy-planemo/galaxy/tool-data/shared/ucsc/chrom/?.len\"", "dbkey": "\"?\"", "sheet": "\"data\""}, "state": "ok", "stderr": "", "stdout": "", "tool_id": "xls2tab_R", "tool_stderr": "", "tool_stdout": "", "update_time": "2021-04-22T22:49:24.281312", "user_email": "[email protected]"}, "status": "success"}}, {"id": "functional.test_toolbox.TestForTool_xls2tab_R.test_tool_000001", "has_data": true, "data": {"tool_id": "xls2tab_R", "tool_version": "0.2", "test_index": 1, "time_seconds": 27.53522253036499, "inputs": {"input1": {"src": "hda", "id": "54f2a3a23292eb07"}, "sheet": "Feuille 1"}, "job": {"command_line": "Rscript '/home/chris/.planemo/planemo_tmp_nu4hmbtd/xls2tab.R' '/tmp/tmp1jl_0anm/files/9/c/f/dataset_9cf4ef19-a19e-4ba8-a1e1-7214cd3ebdcc.dat' 'Feuille 1' '/tmp/tmp1jl_0anm/files/7/c/b/dataset_7cb8e062-2359-4556-9fe7-7d4fc74f1e5d.dat'", "command_version": "", "create_time": "2021-04-22T22:49:44.509101", "exit_code": 0, "external_id": "25389", "galaxy_version": "20.01", "history_id": "5729865256bc2525", "id": "8155e4b4bf1581ff", "inputs": {"input1": {"id": "54f2a3a23292eb07", "src": "hda", "uuid": "9cf4ef19-a19e-4ba8-a1e1-7214cd3ebdcc"}}, "job_messages": [], "job_metrics": [], "job_stderr": "", "job_stdout": "", "model_class": "Job", "outputs": {"output": {"id": "8155e4b4bf1581ff", "src": "hda", "uuid": "7cb8e062-2359-4556-9fe7-7d4fc74f1e5d"}}, "params": {"__input_ext": "\"xlsx\"", "chromInfo": "\"/home/chris/galaxy-planemo/galaxy/tool-data/shared/ucsc/chrom/?.len\"", "dbkey": "\"?\"", "sheet": "\"Feuille 1\""}, "state": "ok", "stderr": "", "stdout": "", "tool_id": "xls2tab_R", "tool_stderr": "", "tool_stdout": "", "update_time": "2021-04-22T22:49:51.844537", "user_email": "[email protected]"}, "status": "success"}}], "summary": {"num_tests": 2, "num_failures": 0, "num_errors": 0, "num_skips": 0}, "exit_code": 0}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drosofff can you remove those files and add them to the .gitignore fle please?

args = commandArgs(trailingOnly = TRUE)
sheet <- read_excel(args[1],sheet = args[2])
write.table(sheet,"out.tabular", sep = "\t", row.names = FALSE)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also get rid of the quotes for every cell or are they needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes... I had the same idea. I guess it is up to @yvanlebras. We can leave with it

Copy link

@ColineRoyaux ColineRoyaux Apr 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just asked him, ok to remove the quotes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants