update to new ae2wtlib api #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the heads-up. Am I good to merge this already in that case? |
|
yes |
|
the new ae2wtlib version is now released on curseforge and modrinth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ae2wtlib is getting a new api which is supposed to be JiJed by mods adding their own terminals.
this has the advantage that the terminal related code isn't duplicated between ae2wtlib present and ae2wtlib not present.
it is however also a breaking change for all mods interacting with ae2wtlib, so I am making this PR before I release the ae2wtlib update publicly in order to minimize the impact
I marked megacells <= 4.0.0-alpha incompatible in ae2wtlib (but excluded 0.0.0 so it works in dev)
since this now uses the api mod, there shouldn't be any weird issues with people accidentally using an old ae2wtlib version with this PR (except that they couldn't put greater energy cards in ae2wtlib terminals)
I will probably release the ae2wtlib update today or tomorrow