v0.8.0 🍉 - Bugfixes, Pagination and General Improvements #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- specific rollup properties can be null, which lead to issues of setting the content of the property - this fix checks the existence of content and skips setting the content, if it is null (e.g. empty selects, multi_selects etc.) - fixes issue: Rollup that refers to an empty Select property throws exception during database query
- introduce new methods for actively including time ('include Time') of a Date Properties within a Notion Page
- existing init of value for a Date Property will force a date without time
- ::valueWithTime(...) in Date Property and ->setDateTime(...) in Page will force the inclusion of time, if pushed to Notion
- ! breaking: result of ::value(...) of Date Property and ->setDate(...) of Page are changing (time will not be included)
- testing the edge case of the fix "65-rollup-with-empty-select-fix"
- change date formatting within EndointPagesTest (it_assembles_properties_for_a_new_page) - making sure to use 'Y-m-d' format instead of 'c', to match new Date Property handling
- fix problem with next_cursor handling for database queries - added raw extraction (->fillResult()) for 'has_more' and 'next_cursor' in EntityCollection (e.g. executed on querying databases) - added ->offsetByResponse(...) for handling the offset based on the previous query result (query result = EntityCollection) - added public functions for easy access to 'has_more' (->hasMoreEntries()) and 'next_cursor' (->nextCursor()) in EntityCollection
- and add return type to StartCursor '__toString'
- test without offset in query and with next_cursor in response - test with offset in query (from previous response) and without next_cursor in response
…om/5am-code/laravel-notion-api into feature/better-pagination-handling
- refactor 'isset' to Arr::exists - evaluate if time is included, based on 'T' in datetime-string (when reading a date property from Notion) - allow return of null within ->getEnd() getter (allow same in RichDate::class) - add ->hasTime() getter, which calls ->hasTime() from RichDate::class (content) - refactor ->getHasTime() from RichDate::class to ->hasTime()
- add date with and without time in page response stub - assert true and false, if time is included - add these two additional properties within assert count of page results
65 rollup with empty select fix
polish/fix: control over 'includeTime' of Date
Feature/better pagination handling: add: better pagination handling
johguentner
changed the title
johguentner
changed the title
mechelon
approved these changes
Aug 1, 2022
- return null in helper-functions, if content is null: hasTime, getEnd - throw HandlingException::class, if getStart is called on empty content
This was referenced Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: