-
Notifications
You must be signed in to change notification settings - Fork 362
Conversation
…nconsistent request finishes, debouncing tbd
Travis automatic deployment: Storybook book automatic deployment: |
Travis automatic deployment: Storybook book automatic deployment: |
Answering to your question on the OPTIMIZATION IDEA, it looks good to me. Just remember that the user could also refresh the app, so that should be handled too. |
Travis automatic deployment: Storybook book automatic deployment: |
Travis automatic deployment: Storybook book automatic deployment: |
In this PR:
README.MD
to use yarn since we use yarn on our ci and IMO it's better to keep it the same everywheresrc/routes/safe/store/middleware/safeStorage.js:24
. This was kind of required by the next change I'll describePreviously tokens state looked like this:
now it's just
and activeTokens for each safe are stored on Safe's state in activeTokens array
I wouldn't recommend using SessionStorage gruns/ImmortalDB#22
Disable cookie store by default. gruns/ImmortalDB#6
OPTIMIZATION IDEA
Currently it saves safes/tokens to local storage on each
UPDATE_SAFE and ADD_SAFE
actions. I think maybe it do it right before the app window is closed? So the storage is not bombed with updates every 10-15 seconds. I need to do some research about this approach. Would love to hear your opinion you have done something like that :)