This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nconsistent request finishes, debouncing tbd
Travis automatic deployment: Storybook book automatic deployment: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
README.MD
to use yarn since we use yarn on our ci and IMO it's better to keep it the same everywheresrc/routes/safe/store/middleware/safeStorage.js:24
. This was kind of required by the next change I'll describePreviously tokens state looked like this:
now it's just
and activeTokens for each safe are stored on Safe's state in activeTokens array
I wouldn't recommend using SessionStorage gruns/ImmortalDB#22
Disable cookie store by default. gruns/ImmortalDB#6
OPTIMIZATION IDEA
Currently it saves safes/tokens to local storage on each
UPDATE_SAFE and ADD_SAFE
actions. I think maybe it do it right before the app window is closed? So the storage is not bombed with updates every 10-15 seconds. I need to do some research about this approach. Would love to hear your opinion you have done something like that :)