Web User Interface | Integration of new Python module #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjwbbc
reviewed
Nov 13, 2024
management-ui/server.py
Outdated
Comment on lines
38
to
43
| from rt_media_configuration.media_configuration import MediaConfiguration | ||
| from rt_media_configuration.importers.m1_importer import M1SessionImporter | ||
| from rt_media_configuration.media_entry import MediaEntry | ||
| from rt_media_configuration.media_distribution import MediaDistribution | ||
| from rt_media_configuration.media_entry_point import MediaEntryPoint | ||
| from rt_media_configuration.media_app_distribution import MediaAppDistribution |
There was a problem hiding this comment.
Not wrong, but I thought I'd point out that those classes are replicated in the top level rt_media_configuration module. So you can just do: from rt_media_configuration import MediaConfiguration, M1SessionImporter, MediaEntry, MediaDistribution, MediaEntryPoint, MediaAppDistribution
| else: | ||
| data_store = None | ||
| if _media_configuration is None: | ||
| _media_configuration = await MediaConfiguration(persistent_data_store=data_store) |
There was a problem hiding this comment.
You can get MediaConfiguration to use your M1Session object for its synchronisation by providing it in the m1_session argument to the MediaConfiguration initialisation. So this line would become:
_media_configuration = await MediaConfiguration(persistent_data_store=data_store, m1_session=session)
Comment on lines
+97
to
+98
| importer = M1SessionImporter(session) | ||
| await importer.import_to(_media_configuration) |
There was a problem hiding this comment.
This should be equivalent to:
_media_configuration.restoreModel()… the entire module, improved documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR expands 5G-MAG RT Application Provider Web User Interface, with server endpoints to integrate and process new Media Configuration module in order to create m8.json file for the overall 5GMS architecture.
Related discussion: #43
Related issue: #52