Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return undefined instead of an emtpy object #1

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

return undefined instead of an emtpy object #1

wants to merge 1 commit into from

Commits on Jul 22, 2016

  1. return undefined instead of an emtpy object 

    Meteor login handler runner expects either and object with an user id, or an error, otherwise you are not supposed to return anything, or undefined, so it can continue with other login handlers.
Currently we are returning an empty object, when we are sure the login attempt is not meant for this handler. The empty object however will actually cause an exception and stop the handler from running more login attempts later in the chain and throw an error instead.

Account_server.js:318

throw new Error("A login method must specify a userId or an error");
    @51smith
    51smith authored Jul 22, 2016
    Configuration menu
    Copy the full SHA
    d334ac3 View commit details
    Browse the repository at this point in the history