-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#85 Override executed script #119
Conversation
- ExecutionMode.FORCE_MARK_AS_EXECUTED is now deprecated. Use Action.MARK_AS_EXECUTED. - ExecutionStatus.FORCE_MARKED_AS_EXECUTED is deprecated. The action is saved on the executed script - ExecutionStatus.SHOULD_BE_EXECUTED was removed because useless now we have action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this can't be in a review comment, I'm telling here: the action of DatamaintainConfig
should be added in the log
function of the class.
I don't see anything regarding the new option for the configuration to enable Datamaintain to choose to override executed scripts, is that normal?
modules/core/src/main/kotlin/datamaintain/core/config/DatamaintainConfig.kt
Outdated
Show resolved
Hide resolved
modules/core/src/main/kotlin/datamaintain/core/script/Script.kt
Outdated
Show resolved
Hide resolved
modules/core/src/main/kotlin/datamaintain/core/script/FileScript.kt
Outdated
Show resolved
Hide resolved
modules/core/src/main/kotlin/datamaintain/core/step/executor/Executor.kt
Outdated
Show resolved
Hide resolved
modules/core/src/main/kotlin/datamaintain/core/step/executor/Executor.kt
Outdated
Show resolved
Hide resolved
...datamaintain/core/step/sort/ByCaseInsensitiveSeparatorFreeAlphabeticalSortingStrategyTest.kt
Show resolved
Hide resolved
modules/driver-mongo/src/test/kotlin/datamaintain/db/driver/mongo/InMemoryScript.kt
Outdated
Show resolved
Hide resolved
val set = "\$set"; | ||
|
||
executeMongoQuery(""" | ||
db.$EXECUTED_SCRIPTS_COLLECTION.update({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could use an updateOne
Override executed script
Resolves/Fixes/Closes #85