Skip to content

Commit

Permalink
refacto #143 Removed useless methods in driver-mongo
Browse files Browse the repository at this point in the history
ExecutedScript are only serialized and LightExecutedScript are only deserialized.
  • Loading branch information
asolovieff authored and Lysoun committed Nov 3, 2021
1 parent bcf0249 commit ddafb62
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 25 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@ package datamaintain.db.driver.mongo
import datamaintain.core.script.ExecutedScript

interface ExecutedScriptJsonParser {
// parse a stringify json array to an Array of ExecutedScript
fun parseArrayOfExecutedScripts(executedScriptJsonArray: String): Sequence<ExecutedScript>

// Serialize an ExecutedScript to a stringify json document
fun serializeExecutedScript(executedScript:ExecutedScript): String
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,4 @@ import datamaintain.core.script.LightExecutedScript
interface LightExecutedScriptJsonParser {
// parse a stringify json array to an Array of LightExecutedScript
fun parseArrayOfLightExecutedScripts(lightExecutedScriptJsonArray: String): Sequence<LightExecutedScript>

// Serialize an LightExecutedScript to a stringify json document
fun serializeLightExecutedScript(lightExecutedScript: LightExecutedScript): String
}
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@ fun LightExecutedScriptDb.toLightExecutedScript() = LightExecutedScript(
checksum,
identifier
)
fun LightExecutedScript.toLightExecutedScriptDb() = LightExecutedScriptDb(
name = name,
checksum = checksum,
identifier = identifier
)

// Copy of ExecutedScript, this is aim for add the Serializable annotation
// Annotation allow to serialize/deserialize this object to/from a bson document (support json only)
Expand Down Expand Up @@ -71,13 +66,6 @@ class KJsonParser: ExecutedScriptJsonParser, LightExecutedScriptJsonParser {
val configuration = JsonConfiguration.Stable.copy(ignoreUnknownKeys = true)
private val mapper = Json(configuration)

override fun parseArrayOfExecutedScripts(executedScriptJsonArray: String): Sequence<ExecutedScript> {

return mapper.parse(ExecutedScriptDb.serializer().list, executedScriptJsonArray)
.map { it.toExecutedScript() }
.asSequence()
}

override fun serializeExecutedScript(executedScript: ExecutedScript): String {
val executedScriptDb = executedScript.toExecutedScriptDb()

Expand All @@ -89,10 +77,4 @@ class KJsonParser: ExecutedScriptJsonParser, LightExecutedScriptJsonParser {
.map { it.toLightExecutedScript() }
.asSequence()
}

override fun serializeLightExecutedScript(lightExecutedScript: LightExecutedScript): String {
val lightExecutedScriptDb = lightExecutedScript.toLightExecutedScriptDb()

return mapper.stringify(LightExecutedScriptDb.serializer(), lightExecutedScriptDb)
}
}

0 comments on commit ddafb62

Please sign in to comment.