-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add switchable storage backends. #286
base: master
Are you sure you want to change the base?
Conversation
And added Google Drive as well. |
This is really ambitious! I checked out the code and could fix some things (like the new RedditRipper changes), but it looks like it broke the VideoRipper -- rips are no longer saved to "videos" subdirectory. I can't find a way to fix this. |
Do they get saved anywhere else? Admittedly I don't have any videos to rip. I messed around a lot with the directory naming and stuff (AbstractRipper) so I suspect they might be missing the prefix. |
Videos are saved to the root folder (where I tried inserting Here's a SFW video you can test the ripper with: |
Ah, I remember now. The issue was that I just didn't port the |
I'm interested in this but it's a significant change so I'm not going to prioritize this for the moment. In the meantime, any work you could put in to test it and clean it up would be appreciated! |
@bobobo1618 are you still interested in getting this PR merged? If so make it in https://github.com/RipMeApp/ripme as development has moved there |
@cyian-1756 Ultimately I think we need to decide whether we want to take this, and if so, we need to adopt the code and fix it up ourselves (port it over to ripmeapp/ripme) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Google RipMe github
@@ -188,7 +184,7 @@ public void retrievingSource(String url) { | |||
* @param saveAs | |||
* Where the downloaded file is stored. | |||
*/ | |||
public abstract void downloadCompleted(URL url, File saveAs); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Google RipMe github
Followup to #285.
This is my (working but horrendously messy) code that adds Google Cloud Storage and Amazon S3 as storage backends for ripme.