Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switchable storage backends. #286

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bobobo1618
Copy link

Followup to #285.

This is my (working but horrendously messy) code that adds Google Cloud Storage and Amazon S3 as storage backends for ripme.

@bobobo1618 bobobo1618 mentioned this pull request Jan 2, 2016
@bobobo1618
Copy link
Author

And added Google Drive as well.

@4pr0n
Copy link
Owner

4pr0n commented Apr 17, 2016

This is really ambitious!

I checked out the code and could fix some things (like the new RedditRipper changes), but it looks like it broke the VideoRipper -- rips are no longer saved to "videos" subdirectory. I can't find a way to fix this.

@bobobo1618
Copy link
Author

Do they get saved anywhere else? Admittedly I don't have any videos to rip. I messed around a lot with the directory naming and stuff (AbstractRipper) so I suspect they might be missing the prefix.

@4pr0n
Copy link
Owner

4pr0n commented Apr 17, 2016

Videos are saved to the root folder (where ripme.jar is, one dir above rips).

I tried inserting videos into the path (in VideoRipper.java) but it tried to save files to {full_path_to_ripme.jar} / {full_path_to_videos_dir}

Here's a SFW video you can test the ripper with: https://vid.me/4ahQ

@bobobo1618
Copy link
Author

Ah, I remember now.

The issue was that I just didn't port the DownloadVideoThread over to the new infrastructure. It seems to work now but looking through it it's likely I've left a few little bugs due to my lack of understanding the code.

@metaprime
Copy link
Collaborator

I'm interested in this but it's a significant change so I'm not going to prioritize this for the moment. In the meantime, any work you could put in to test it and clean it up would be appreciated!

@cyian-1756
Copy link
Contributor

@bobobo1618 are you still interested in getting this PR merged? If so make it in https://github.com/RipMeApp/ripme as development has moved there

@metaprime
Copy link
Collaborator

metaprime commented Nov 21, 2017

@cyian-1756 Ultimately I think we need to decide whether we want to take this, and if so, we need to adopt the code and fix it up ourselves (port it over to ripmeapp/ripme)

Copy link

@EPAVAIPOCRLH EPAVAIPOCRLH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google RipMe github

@@ -188,7 +184,7 @@ public void retrievingSource(String url) {
* @param saveAs
* Where the downloaded file is stored.
*/
public abstract void downloadCompleted(URL url, File saveAs);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google RipMe github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants