Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and rm rate limit #575

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Cleanup and rm rate limit #575

merged 4 commits into from
Jul 23, 2024

Conversation

clarabakker
Copy link
Member

Miscellaneous cleanup:

  • Change clean_up_webdev_wfrs to run manually and correct test UUIDs
  • fastqc and fastq-first-line checks are no longer rate limited
  • Correct key used for fruit fly reference files and parameters

@clarabakker clarabakker requested a review from aschroed July 22, 2024 17:53
Copy link
Member

@aschroed aschroed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Is md5 still on dockerhub - and is the only one still rate limited?

@clarabakker
Copy link
Member Author

Yes, just md5 is still rate limited. I can wait to merge in order to add it to the PR.

@aschroed
Copy link
Member

No need to wait to merge. I just wanted to make sure and when you do remove the final rate limit I suggest adding a comment to the function in wfr_utils that formerly did the rate limiting as documentation in case it becomes useful again in the future.

@clarabakker clarabakker merged commit 00888e6 into master Jul 23, 2024
1 check failed
@clarabakker clarabakker deleted the cleanup_and_rm_rate_limit branch July 23, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants