Bug fix for failing biorxiv update check #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ID causing an exception
clarabakker
reviewed
Feb 2, 2024
clarabakker
reviewed
Feb 2, 2024
clarabakker
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An exception was being thrown as the doi ID used for a pub contained a v# when submitted. That doi was resolvable and the pub page looked fine. However, when the biorxiv api was queried with that doi+v extension it returned an unexpected and handled response.
Now this version bit is parsed out of the ID so api call works as expected
Added conditionals to be sure.
Also now tracking potentially misformatted doi values so they are reported and can be fixed if necessary.