Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit images #68

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

Audit images #68

wants to merge 28 commits into from

Conversation

madvid
Copy link
Contributor

@madvid madvid commented Sep 4, 2022

Description

Please provide a detailed description of what was done in this PR.
Precise the issue that you are resolving.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functionals / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

Additional comments

Please post additional comments in this section if you have them, otherwise delete it.

@madvid
Copy link
Contributor Author

madvid commented Sep 4, 2022

J'ai bougé ce qui m'a semblé être en lien avec l'audit dans cette branche. (@COTHSC )Tu pourras checker si c'est bon (s'il y a tout comme tu as sur ta branche en lien avec l'audit). Il me semble que j'ai oublié d'exclure le commit de Roberto, mais tinquietes j'ai déjà mergé une branche avec que la doc donc tu peux git reset --hard [sha du commit de roberto] pour virer le commit de doc

@cnstll
Copy link
Contributor

cnstll commented Sep 19, 2022

In audit.csv, huge difference between the theoretical time interval between frames and the calculated time interval between frames.
Missing metadata for "220503_TPS_N2-zoom197_20ms_2" hence no data is generated in audit.csv. Calculated video length can be anormaly high due to high calculated interval between images. @COTHSC can you have a look over the results ? ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants