Revert "Introduce APICAST_LUA_SOCKET_KEEPALIVE_REQUESTS environment variable" #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eguzki
approved these changes
Nov 6, 2024
dfennessy
reviewed
Nov 6, 2024
|
|
||
| ## Dependencies | ||
|
|
||
| APIcast uses LuaRocks, the package manager for Lua modules, to install dependencies. With a correct configuration, LuaRocks installs dependencies into the correct path where OpenResty can see them. | ||
| APIcast uses LuaRocks, the package manager for Lua modules, to install dependencies. With a correct configuration, LuaRocks installs dependencies into the correct path where OpenResty can see them. |
There was a problem hiding this comment.
Suggested change
| APIcast uses LuaRocks, the package manager for Lua modules, to install dependencies. With a correct configuration, LuaRocks installs dependencies into the correct path where OpenResty can see them. | |
| APIcast uses LuaRocks, the package manager for Lua modules, to install dependencies. With the proper configuration, LuaRocks installs dependencies into the path accessible to OpenResty. |
dfennessy
requested changes
Nov 6, 2024
|
Thanks @dfennessy, you are fast 😄 . This one revert the previous PR, and somehow the build.md was changed. 😓 . I would prefer to keep the docs unchanged if you don't mind. |
dfennessy
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1496