Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove third party service from the Lizmap API #78

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

Gustry
Copy link
Member

@Gustry Gustry commented May 27, 2024

It looks like not the best idea to check for a "predefined list" of SERVICE to look for

For Cadastre and AtlasPrint, it looks more logical to check if the plugin is returned in the list of plugins installed, instead of hardcoding a list of service in the plugin itself.

Fixing a logging error about unknonwn service as well : 3liz/lizmap-web-client#4462

If I'm not wrong, it's not used in LWC source code anyway

@Gustry Gustry merged commit 4a20e21 into 3liz:master Jun 3, 2024
7 checks passed
@Gustry Gustry deleted the remove-cadastre branch June 3, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant