Use quote format for layers parameter name in output urls

3liz · Mar 17, 2023 · 3859985 · 3859985
1 parent 0341db0
commit 3859985
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,11 @@
 
 ## Unreleased
 
+* Use quote format for layers parameter name in output urls
+    - Fix urlencoded parameters with space: 
+      i.e: `layers=foo%20bar` instead of `layers=foo+bar` that
+      causes problem with Qgis server.
+
 ## 1.8.4 - 2022-12-16
 
 * PEP8 Code style

diff --git a/Makefile b/Makefile
@@ -3,7 +3,7 @@
 # qypws makefile
 #
 
-VERSION:=1.8.4
+VERSION:=1.8.5
 
 ifndef CI_COMMIT_TAG
 VERSION_TAG=$(VERSION)rc0

diff --git a/pyqgiswps/executors/io/layersio.py b/pyqgiswps/executors/io/layersio.py
@@ -12,7 +12,7 @@
 import traceback
 
 from pathlib import Path
-from urllib.parse import urlparse, urlencode, parse_qs
+from urllib.parse import quote, urlparse, urlencode, parse_qs
 
 from qgis.core import (QgsProcessing,
                        QgsProcessingParameterDefinition,
@@ -518,7 +518,7 @@ def parse_response(value: Any, outdef: QgsProcessingOutputDefinition, out: WPSOu
     result = add_layer_to_load_on_completion(value, outdef, context)
     if result:
         result = ','.join(result)
-        out.url = output_url + '&' + urlencode((('layers', result),))
+        out.url = output_url + '&' + urlencode((('layers', result),), quote_via=quote)
     else:
         out.url = output_url